Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[copy update] WD-4341 revamp on /ceph #13052

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

pedoch
Copy link
Contributor

@pedoch pedoch commented Jul 25, 2023

Done

  • Copy revamp on /ceph

QA

  • Check out the demo here and compare it with the changes requested in the copy doc.
    • Be sure to test on mobile, tablet and desktop screen sizes

Issue / Card

Help

QA steps - Commit guidelines

@webteam-app
Copy link

webteam-app commented Jul 25, 2023

Demo starting at https://ubuntu-com-13052.demos.haus/ceph

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #13052 (fe66ce6) into main (384749e) will decrease coverage by 0.11%.
Report is 9 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13052      +/-   ##
==========================================
- Coverage   74.90%   74.80%   -0.11%     
==========================================
  Files         107      107              
  Lines        2873     2881       +8     
  Branches      928      936       +8     
==========================================
+ Hits         2152     2155       +3     
- Misses        699      704       +5     
  Partials       22       22              

see 1 file with indirect coverage changes

@camillet16
Copy link

Screen Shot 2023-07-27 at 11 53 57 AM

Replace icon with this svg:
machines

After this LGTM :)

Copy link
Contributor

@mtruj013 mtruj013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor changes needed

templates/ceph/index.html Outdated Show resolved Hide resolved
templates/ceph/index.html Outdated Show resolved Hide resolved
@pedoch
Copy link
Contributor Author

pedoch commented Jul 27, 2023

Thanks for looking at this @mtruj013!

@pedoch pedoch merged commit 656e43e into canonical:main Jul 27, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants