Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement /credentials/shop/webhook_responses in flask view #13469

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Jan 17, 2024

Done

  • Removed/credentials/shop/webhook_responses that was previously a React app and implemented as flask view

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/
    • Be sure to test on mobile, tablet and desktop screen sizes
  • Go to /credentials/shop/webhook_responses
  • The page should function as it did previously with the React implementation

Issue / Card

Fixes WD-8194

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Demo starting at https://ubuntu-com-13469.demos.haus

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.49%. Comparing base (6e36f97) to head (d3afd16).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13469   +/-   ##
=======================================
  Coverage   74.49%   74.49%           
=======================================
  Files         107      107           
  Lines        2854     2854           
  Branches      954      954           
=======================================
  Hits         2126     2126           
  Misses        704      704           
  Partials       24       24           

webapp/shop/cred/views.py Outdated Show resolved Hide resolved
webapp/shop/cred/views.py Outdated Show resolved Hide resolved
@jpmartinspt jpmartinspt merged commit 17d4f9e into canonical:main Mar 21, 2024
15 checks passed
@britneywwc britneywwc deleted the flask-cred-webhook branch March 25, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants