Update copy on kubernetes/install #13581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://ubuntu-com-13581.demos.haus |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## k8s-bubble-refresh #13581 +/- ##
===================================================
Coverage 74.41% 74.41%
===================================================
Files 107 107
Lines 2838 2838
Branches 946 946
===================================================
Hits 2112 2112
Misses 702 702
Partials 24 24 |
akbarkz
force-pushed
the
k8s-bubble-refresh
branch
from
115313d
to
07f0c46
Compare
akbarkz
requested changes
Feb 15, 2024
| @@ -477,14 +523,14 @@ <h2>Kubernetes resources</h2> | |||
| <p class="p-heading-icon__title p-muted-heading" style="color: #fff;">Data Sheet</p> | |||
| </div> | |||
| </div> | |||
| <p><a class="p-link--inverted" href="https://assets.ubuntu.com/v1/b5f9ae49-Enterprise_Kubernetes_Datasheet.pdf">Kubernetes for the enterprise</a></p> | |||
| <p><a class="p-link--inverted" href="https://assets.ubuntu.com/v1/b5f9ae49-Enterprise_Kubernetes_Datasheet.pdf">Kubernetes for the enterprise ›</a></p> | |||
There was a problem hiding this comment.
This change is not specified in the copy doc
There was a problem hiding this comment.
Chevron usage is not decided on the copydoc level, but on the design level. usually there is some consistency of use within a page, so In this case I was trying to get all the links to align with one another
| @@ -496,7 +542,7 @@ <h2>Kubernetes resources</h2> | |||
| <p class="p-heading-icon__title p-muted-heading" style="color: #fff;">Industry Report</p> | |||
| </div> | |||
| </div> | |||
| <p><a class="p-link--inverted" href="https://juju.is/cloud-native-kubernetes-usage-report-2021">The Kubernetes and cloud native operations report 2021</a></p> | |||
| <p><a class="p-link--inverted" href="https://juju.is/cloud-native-kubernetes-usage-report-2022">The Kubernetes and cloud native operations report 2022 ›</a></p> | |||
There was a problem hiding this comment.
Suggested change
| <p><a class="p-link--inverted" href="https://juju.is/cloud-native-kubernetes-usage-report-2022">The Kubernetes and cloud native operations report 2022 ›</a></p> | |
| <p><a class="p-link--inverted" href="https://juju.is/cloud-native-kubernetes-usage-report-2022">The Kubernetes and cloud native operations report 2022</a></p> |
| @@ -515,7 +561,7 @@ <h2>Kubernetes resources</h2> | |||
| <p class="p-heading-icon__title p-muted-heading" style="color: #fff;">Whitepaper</p> | |||
| </div> | |||
| </div> | |||
| <p><a class="p-link--inverted" href="/engage/kubernetes-deployment-enterprise-whitepaper">Five strategies to accelerate Kubernetes deployment in the enterprise</a></p> | |||
| <p><a class="p-link--inverted" href="/engage/kubernetes-deployment-enterprise-whitepaper">Five strategies to accelerate Kubernetes deployment in the enterprise ›</a></p> | |||
There was a problem hiding this comment.
This change is not specified in the copy doc
akbarkz
added
Review: QA +1
Review: Code +1
and removed
Review: QA needed
Review: Code needed
labels
akbarkz
approved these changes
Feb 15, 2024
akbarkz
pushed a commit
that referenced
this pull request
Feb 19, 2024
* Update copy on kubernetes/install * Update with review suggestions
akbarkz
pushed a commit
that referenced
this pull request
Feb 21, 2024
* Update copy on kubernetes/install * Update with review suggestions
akbarkz
pushed a commit
that referenced
this pull request
Feb 23, 2024
* Update copy on kubernetes/install * Update with review suggestions
akbarkz
pushed a commit
that referenced
this pull request
Feb 26, 2024
* Update copy on kubernetes/install * Update with review suggestions
akbarkz
pushed a commit
that referenced
this pull request
Feb 27, 2024
* Update copy on kubernetes/install * Update with review suggestions
akbarkz
pushed a commit
that referenced
this pull request
Mar 4, 2024
* Update copy on kubernetes/install * Update with review suggestions
akbarkz
pushed a commit
that referenced
this pull request
Mar 12, 2024
* Update copy on kubernetes/install * Update with review suggestions
akbarkz
pushed a commit
that referenced
this pull request
Mar 20, 2024
* Update copy on kubernetes/install * Update with review suggestions
akbarkz
pushed a commit
that referenced
this pull request
Apr 1, 2024
* Update copy on kubernetes/install * Update with review suggestions
akbarkz
pushed a commit
that referenced
this pull request
Apr 11, 2024
* Update copy on kubernetes/install * Update with review suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-8850
Screenshots
[If relevant, please include a screenshot.]
Help
QA steps - Commit guidelines