Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-9266 Update /ai page #13626

Merged
merged 1 commit into from
Mar 5, 2024
Merged

WD-9266 Update /ai page #13626

merged 1 commit into from
Mar 5, 2024

Conversation

carkod
Copy link
Contributor

@carkod carkod commented Feb 29, 2024

Done

QA

  • Go to https://ubuntu-com-13626.demos.haus/ai and check the link for "Read more about Edge AI" has been added.
  • [List additional steps to QA the new features or prove the bug has been resolved]

Issue / Card

Fixes https://warthogs.atlassian.net/jira/software/c/projects/WD/boards/932

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Demo starting at https://ubuntu-com-13626.demos.haus

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (8ac389f) to head (67448d6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13626   +/-   ##
=======================================
  Coverage   74.46%   74.46%           
=======================================
  Files         107      107           
  Lines        2847     2847           
  Branches      948      948           
=======================================
  Hits         2120     2120           
  Misses        703      703           
  Partials       24       24           

@carkod carkod force-pushed the update-ai-wd-9266 branch 3 times, most recently from 170edcd to af14202 Compare February 29, 2024 11:02
@carkod carkod changed the title Update ai WD-9266 WD-9266 Update /ai page Feb 29, 2024
@@ -471,6 +471,7 @@ <h2>Use modular platforms to run AI at the edge or in large clouds</h2>
<li class="p-list__item is-ticked">Low-ops, streamlined lifecycle management</li>
<li class="p-list__item is-ticked">A modular and open source suite for reusable deployments</li>
</ul>
<a href="/blog/edge-ai" class="p-button">Read more about Edge AI</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this look like a regular link instead of a button?

Copy link
Contributor Author

@carkod carkod Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? The other links are also buttons, it's not a link inside of a paragraph

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is my understanding that what in the copy docs is wrapped in [] needs to be showed as a button. This one doesn't have the [], so it should probably be a link - unless the author unintentionally forgot to put the [] around it. Could you please check this with the author and/or the designers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lorumic done, updated to link.

@akbarkz akbarkz merged commit a002b52 into canonical:main Mar 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants