WD-9834 - add section to /download/amd #13684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://ubuntu-com-13684.demos.haus |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13684 +/- ##
=======================================
Coverage 74.49% 74.49%
=======================================
Files 107 107
Lines 2854 2854
Branches 954 954
=======================================
Hits 2126 2126
Misses 704 704
Partials 24 24 |
akbarkz
requested changes
Mar 20, 2024
templates/download/amd/tab-1.html
Outdated
| @@ -39,6 +39,17 @@ <h3>Ubuntu Server 22.04 LTS</h3> | |||
| </div> | |||
| </div> | |||
|
|
|||
| <div class="row p-strip u-no-padding--top"> | |||
There was a problem hiding this comment.
since this section is the same for all three tabs, can you please make it a partial and reuse in all three?
akbarkz
added
Review: QA +1
Review: Code -1
and removed
Review: QA needed
Review: Code needed
labels
akbarkz
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Add 'Are you working on a commercial project?' section to /download/amd
QA
Issue / Card
WD-9834