WD-9610 Rebrand Raspi download thank you

[carkod]

QA

• Go to https://ubuntu-com-13712.demos.haus/download/raspberry-pi select an ISO image, you'll be redirected to the "thank you" page.
• Check that page against copy docs and design below in the screenshot section
  • Be sure to test on mobile, tablet and desktop screen sizes
• [List additional steps to QA the new features or prove the bug has been resolved]

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-9610

Screenshots (design review)

Help

QA steps - Commit guidelines

[webteam-app]

Demo

Jenkins

demos.haus

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.49%. Comparing base (ae74303) to head (93ec17f).

Additional details and impacted files

@@                   Coverage Diff                    @@
##           download-bubble-wd-8482   #13712   +/-   ##
========================================================
  Coverage                    74.49%   74.49%           
========================================================
  Files                          107      107           
  Lines                         2854     2854           
  Branches                       954      954           
========================================================
  Hits                          2126     2126           
  Misses                         704      704           
  Partials                        24       24           

[juanruitina]

Nice job, LGTM!

[lyubomir-popov]

looks good, please just insert a break in front of "Go":

[akbarkz]

I found a weird behavior while testing. Whevener you click on "Subscribe to our newsletter" it redirects you to /download/server page no matter if you are downloading desktop, server or core image. Even if I go to /download/desktop and download desktop image I am still redirected to /download /server. I think this is incorrect. Depending on the image you are downloading you should be redirected to the corresponding page OR to the page that is common to all of them, like landing download page. @juanruitina wdyt?

[juanruitina]

Indeed, @akbarkz, all that should make sense. I've also noticed that we are also using the server form partial in /desktop/thank-you. Let me inquire about which specific forms they should be pointing to.

[carkod]

@akbarkz @juanruitina Yeah, that should redirect to their respective pages. I've updated the partial to have their respective "returnUrls"

[akbarkz]

Found two bugs:

1. When you go to /download/desktop and click on any download button it fails with 500
2. When you go to /download/raspberry-pi and click on any download button the Thank You page opens. Then enter your email address to sign up for a newsletter. It will redirect to /download/raspberry-pi which is correct. Now close the pop-up message that says "Thank you...". It then redirects you again to the Thank You page and downloads an image again.

[carkod]

This is just file rename, and added the returnUrl parameter, nothing's changed.

[carkod]

• https://ubuntu-com-13712.demos.haus/download/raspberry-pi

1. I just fixed it right after.
2. I fixed it, but that is something that Liza has added, not sure why. It could be breaking something, but this is not the best way to handle a redirect in the onclick, plus it doesn't tell us where this code is used. I believe the right way to do this is to do the redirect in the window.href but I couldn't find the script that is breaking.

[carkod]

Indeed, @akbarkz, all that should make sense. I've also noticed that we are also using the server form partial in /desktop/thank-you. Let me inquire about which specific forms they should be pointing to.

The partial doesn't matter, it's something we devs use to refactor code, I could give it any name, what you may need to inquire is the formId, but I believe we use the same formId everywhere, if we want to change it, it may need changing for the whole site, blogs and other places. I suppose Marketing would need to create campaigns for each of them too.

[akbarkz]

Looks good now @carkod! Thanks for fixing existing bugs too, this are the most important pages on our website, so we need to make sure it works smoothly.
There is one more thing I would like to double check with @juanruitina. Is it correct that we are making the "I agree to receive information about Canonical’s products and services." checkbox required? What if a customer does not want to receive any information, but only receive a newsletter?

[juanruitina]

@akbarkz The newsletter is such information, I would understand we use this to collect explicit consent to comply with GDPR even if it's rather redundant. (We might be taking newsletter subscribers as leads?)

@carkod I left one inline comment.

[carkod]

Ubuntu Server

Yes my understanding is that this check is to actually allow us to send newsletters.

[carkod]

@lizzochek when you are back, can you check what removing this could break? Thanks, let me know if you need help with a better solution. I don' t think applying this globally is good, maybe we should encpasulate it within some function so that it triggers only in that specific situation and also it'd be easier to track where this code is used.