Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rate limiting to cves #13880

Merged
merged 4 commits into from
May 23, 2024
Merged

Add rate limiting to cves #13880

merged 4 commits into from
May 23, 2024

Conversation

samhotep
Copy link
Member

@samhotep samhotep commented May 23, 2024

Done

  • Added rate limiting to the security and notices APIs

QA

Issue / Card

Fixes WD-11323

@webteam-app
Copy link

@samhotep samhotep requested a review from mtruj013 May 23, 2024 10:04
@samhotep samhotep self-assigned this May 23, 2024
webapp/context.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mtruj013 mtruj013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samhotep , LGTM

@samhotep samhotep merged commit 768073e into main May 23, 2024
26 checks passed
@samhotep samhotep deleted the add-rate-limiting-to-cves branch May 23, 2024 12:56
@setharnold
Copy link

setharnold commented May 24, 2024

Hey, are these rates right? Our website is looking pretty useless all day long.

Can the archive.org crawlers be allowlisted, so that we can at least share URLs to users that way?

Thanks.

@carkod
Copy link
Contributor

carkod commented May 24, 2024

There's a decorator version for this library https://flask-limiter.readthedocs.io/en/stable/recipes.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants