Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AWS links #13924

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Update AWS links #13924

merged 3 commits into from
Jun 10, 2024

Conversation

carkod
Copy link
Contributor

@carkod carkod commented Jun 5, 2024 •
edited
Loading

Done

  • 2 copy updates, updating AWS links
  • Djlint formatting
  • Refactor _get_pro section, so that we can reuse it in multiple pages.

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-11844
Fixes https://warthogs.atlassian.net/browse/WD-11846

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@carkod carkod marked this pull request as draft June 5, 2024 13:53
@carkod carkod marked this pull request as ready for review June 5, 2024 14:39
britneywwc
britneywwc reviewed Jun 7, 2024
View reviewed changes
Copy link
Contributor

@britneywwc britneywwc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is some link inconsistencies from the copy docs for 24.04 LTS download link, I'll address it in the copy doc.

@carkod carkod mentioned this pull request Jun 7, 2024
Closed
@carkod
Copy link
Contributor Author

carkod commented Jun 7, 2024

LGTM, there is some link inconsistencies from the copy docs for 24.04 LTS download link, I'll address it in the copy doc.

I believe what I did is actually correct, Carlos Bravo made the mistake. Can I get final review?

britneywwc
britneywwc requested changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@britneywwc britneywwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change the link? It should be the other one

@carkod @britneywwc
Update templates/aws/shared/_get_pro.html
ef964f4 
Co-authored-by: Britney Wang <62298176+britneywwc@users.noreply.github.com>
britneywwc
britneywwc approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@britneywwc britneywwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@carkod carkod merged commit e93384d into canonical:main Jun 10, 2024
13 checks passed
@carkod carkod deleted the update-wd-11844 branch June 10, 2024 08:21
britneywwc pushed a commit to britneywwc/ubuntu.com that referenced this pull request Jul 5, 2024
@carkod @britneywwc
Update AWS links (canonical#13924)
4be16d1 
* WD-11844 Update AWS Ubuntu

* Update templates/aws/shared/_get_pro.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@britneywwc britneywwc britneywwc approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carkod @webteam-app @britneywwc