-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8s1.29+ck3 docs #13997
K8s1.29+ck3 docs #13997
Conversation
Just FYI the 'woke' fails are because we can't police URLs to other sites |
@evilnick where can I see the expected content for the pages and a full list of required changes? Please also provide links to pages no the demo that need to be checked |
These are all the pages that are changed by this PR: https://ubuntu-com-13997.demos.haus/kubernetes/docs/1.29/release-notes There is no copy doc or anything for these pages, the sources are maintained in a different repository. You can see the history of the changes in this PR Thanks for looking |
Content looks good to me according to the PR you mentioned. Please fix listing errors and inclusive name check for me to review code |
@lizzochek I literally can't fix the inclusive language check. e.g.
it's a URL 🤷
it's the name of a deprecated interface which we replaced, but people still need to know what the old one was called so they can update it. I can't add I will look at the jinja_lint test too, which I guess is new since we last updated K8s docs, but from a glance at the output it is complaining mostly about blank lines. The blank lines are usually only there to make the Markdown render properly, and, e.g. "The format for the |
I have removed some anchors the lint-jinja was complaining about. All the other items are necessary either because they are references in code blocks, or blank lines to make the Markdown render properly. I think this test is misconfigured because it shouldn't really be running on Markdown files? There is nothing else I can change on these pages to comply with the checks which doesn't either break the rendering or remove important information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great from a copy perspective, and as @evilnick notes, the woke check failures are expected due to external urls and the lint check failures are expected due to supposedly orphaned keys (even though they're syntactically correct in the code blocks) and blank lines for rendering purposes.
+1.
Thanks @akbarkz |
Done
QA
./run serve
ordotrun
N.B. The content of these changes has already been reviewed