Apply review suggestions and bump version number

canonical · Mar 6, 2024 · 218d014 · 218d014
1 parent d632b98
commit 218d014
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "vanilla-framework",
-  "version": "4.8.1",
+  "version": "4.9.0",
   "author": {
     "email": "webteam@canonical.com",
     "name": "Canonical Webteam"

diff --git a/releases.yml b/releases.yml
@@ -1,3 +1,9 @@
+- version: 4.9.0
+  features:
+    - component: Images
+      url: /docs/patterns/images#media-element-with-spacing
+      status: New
+      notes: We've introduced a way to add spacing above a media element.
 - version: 4.8.0
   features:
     - component: Themes

diff --git a/scss/_patterns_media-container.scss b/scss/_patterns_media-container.scss
@@ -1,5 +1,5 @@
 @mixin vf-p-media-container {
   .p-media-container {
-    margin-top: $sp-unit;
+    margin-top: $spv--small;
   }
 }
diff --git a/scss/standalone/patterns_media-container.scss b/scss/standalone/patterns_media-container.scss
@@ -1,5 +1,5 @@
 @import '../vanilla';
 @include vf-base;
 
-@include vf-b-hr;
+@include vf-p-rule;
 @include vf-p-media-container;
diff --git a/templates/docs/patterns/images.md b/templates/docs/patterns/images.md
@@ -32,7 +32,7 @@ View example of image with a caption
 
 ## Media element with spacing
 
-Adds spacing to the top of a media element.
+Adds spacing to the top of a media element. This is usually needed when image or video is placed below the horizontal rule component to avoid media touching the line.
 
 <div class="embedded-example"><a href="/docs/examples/patterns/image/spacing/" class="js-example">
 View example of media element with spacing