Revert the white success icon for buttons

canonical · Apr 9, 2024 · 711ede5 · 711ede5
1 parent c62cd3d
commit 711ede5
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 15 deletions.
diff --git a/scss/_base_button.scss b/scss/_base_button.scss
@@ -77,8 +77,12 @@
     // stylelint-enable selector-max-type
   }
 
+  // FIXME: buttons are using a custom version of success icon that is not themed
+  // this should ideally be replaced with a themed icon that uses text colour
   %vf-button-white-success-icon {
-    // deprecated, is not needed anymore with new theming
+    & .p-icon--success {
+      @include vf-icon-success($color-x-light, $color-transparent);
+    }
   }
 
   %vf-button-has-icon {

diff --git a/scss/_base_themes.scss b/scss/_base_themes.scss
@@ -41,18 +41,6 @@
     .is-paper {
       @include vf-theme-paper;
     }
-
-    %vf-theme-light {
-      @include vf-theme-light;
-    }
-
-    %vf-theme-paper {
-      @include vf-theme-paper;
-    }
-
-    %vf-theme-dark {
-      @include vf-theme-dark;
-    }
   }
 }
 

diff --git a/scss/_patterns_buttons.scss b/scss/_patterns_buttons.scss
@@ -59,13 +59,15 @@
     &.is-dark {
       @extend %p-button--brand-dark;
     }
+
+    @extend %vf-button-white-success-icon;
   }
 }
 
 @mixin vf-button-positive {
   .p-button--positive {
     @extend %vf-button-base;
-    @extend %vf-theme-dark;
+    @extend %vf-button-white-success-icon;
 
     @include vf-button-pattern(
       $button-background-color: $colors--theme--button-positive-default,
@@ -85,7 +87,7 @@
 @mixin vf-button-negative {
   .p-button--negative {
     @extend %vf-button-base;
-    @extend %vf-theme-dark;
+    @extend %vf-button-white-success-icon;
 
     @include vf-button-pattern(
       $button-background-color: $colors--theme--button-negative-default,