Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box design #186

Closed
richmccartney opened this issue May 8, 2015 · 14 comments
Closed

Box design #186

richmccartney opened this issue May 8, 2015 · 14 comments
Assignees

Comments

@richmccartney
Copy link
Contributor

richmccartney commented May 8, 2015

A box styles to vanilla.

@anthonydillon
Copy link
Contributor

@yaili what should the default box style be?

@yaili
Copy link
Contributor

yaili commented Feb 15, 2016

grey border, white background?

@anthonydillon
Copy link
Contributor

That's what I was thinking. Something super simple for Vanilla. This sound
right?

border: 1px solid $warm-grey;
padding: 20px;
background-colour: $white;

On Mon, 15 Feb 2016, 19:12 Inayaili de León Persson <
notifications@github.com> wrote:

grey border, white background?


Reply to this email directly or view it on GitHub
#186 (comment)
.

@yaili
Copy link
Contributor

yaili commented Feb 16, 2016

Yes. And rounded corners?

@anthonydillon
Copy link
Contributor

Oh yea, not sure. I think You and Spencer should talk about the default
style.

On Tue, 16 Feb 2016 at 09:38 Inayaili de León Persson <
notifications@github.com> wrote:

Yes. And rounded corners?


Reply to this email directly or view it on GitHub
#186 (comment)
.

@yaili
Copy link
Contributor

yaili commented Feb 19, 2016

I think that vanilla should include both simple and highlighted box styles. I think for now we might have to say:

  • default vanilla is what is currently on ubuntu.com in terms of rounded corners
  • current square juju style is a variation

Not sure what the default vanilla drop shadow is, but if Juju is more consistent that ubuntu.com we could decide that juju style is the default one for vanilla.

Make sense?

@yaili
Copy link
Contributor

yaili commented Feb 19, 2016

Thinking about this again, the header style is square in vanilla, so perhaps it makes more sense to have square cornered boxes in vanilla with added rounded corners to ubuntu, in that case Juju would be following plain vanilla style.

@anthonydillon
Copy link
Contributor

Totally, thank you.

On Fri, 19 Feb 2016, 12:43 Inayaili de León Persson <
notifications@github.com> wrote:

I think that vanilla should include both simple and highlighted box
styles. I think for now we might have to say:

  • default vanilla is what is currently on ubuntu.com in terms of
    rounded corners
  • current square juju style is a variation

Not sure what the default vanilla drop shadow is, but if Juju is more
consistent that ubuntu.com we could decide that juju style is the default
one for vanilla.

Make sense?


Reply to this email directly or view it on GitHub
#186 (comment)
.

@anthonydillon
Copy link
Contributor

Sounds good.

On Fri, 19 Feb 2016, 13:09 Anthony Dillon me@anthonydillon.com wrote:

Totally, thank you.

On Fri, 19 Feb 2016, 12:43 Inayaili de León Persson <
notifications@github.com> wrote:

I think that vanilla should include both simple and highlighted box
styles. I think for now we might have to say:

  • default vanilla is what is currently on ubuntu.com in terms of
    rounded corners
  • current square juju style is a variation

Not sure what the default vanilla drop shadow is, but if Juju is more
consistent that ubuntu.com we could decide that juju style is the
default one for vanilla.

Make sense?


Reply to this email directly or view it on GitHub
#186 (comment)
.

@grahambancroft grahambancroft self-assigned this Feb 25, 2016
@yaili
Copy link
Contributor

yaili commented May 5, 2016

Agreed styles:

  • .box (part of Vanilla)
    • background: transparent
    • border: warm-grey
    • no rounded corners (this is added by theme)
  • .card (part of Vanilla)
    • background: white
    • radius: 2px
    • border: drop-shadow @faooful @spencerbygraves can you clarify, I had "grey" in my notes, but that doesn't sound right
  • .box-overlay (part of Vanilla)
    • background: white
    • background opacity: 0.85
    • padding: 20px
  • .card-resource (part of Ubuntu theme)

Utility class:

  • .layer: defines drop shadow
    • mentioned using 200…900 but this was not agreed. Perhaps easier to use 1, 2, 3, …

@yaili yaili removed the design label May 5, 2016
@faooful
Copy link

faooful commented May 5, 2016

@yaili #CDCDCD is the colour that we use for the border with a 2px radius.

@yaili
Copy link
Contributor

yaili commented May 5, 2016

@faooful in the .card too? what is the spec for the shadow?

@faooful
Copy link

faooful commented May 5, 2016

@yaili oh for the card, sorry, we just have drop shadow + the 2px radius.

@yaili yaili added Type: Enhancement Priority: High Should be addressed within current iteration labels Jun 1, 2016
@barrymcgee barrymcgee added Status: More info needed and removed Priority: High Should be addressed within current iteration Status: Triaged labels Jun 10, 2016
@barrymcgee barrymcgee added this to the v1.0 milestone Jun 10, 2016
@barrymcgee
Copy link
Contributor

The dev team is meeting next week to discuss Vanilla naming & structure which will heavily inform how this issue will be actioned.

It would also seem to be that "boxes" and "cards" are two distinct patterns and shouldn't be conflated? More info is needed here so de-prioritising for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants