Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New nav logo padding does not align with content #4530

Closed
sowasred2012 opened this issue Aug 4, 2022 · 1 comment · Fixed by #4555
Closed

New nav logo padding does not align with content #4530

sowasred2012 opened this issue Aug 4, 2022 · 1 comment · Fixed by #4555
Assignees
@bartaz @lyubomir-popov @petermakowski

Comments

@sowasred2012
Copy link
Contributor

Describe the bug

First reported as an issue on canonical/design.ubuntu.com#241

The new "tag" logo is not correctly left aligned with the content below, it seems to be .5rem off.

To Reproduce

Visit https://dqlite-io-209.demos.haus/ or https://design.ubuntu.com/, see that the "tag" logo style does not align on the left hand side with the content below at widths greater than 620px.

Expected behavior

The nav logo and content should be aligned

Screenshots

Peek 2022-08-04 23-53
@sowasred2012 sowasred2012 mentioned this issue Aug 4, 2022
Open
@bartaz
Copy link
Contributor

bartaz commented Aug 17, 2022

Let's fix it outside of the blocked logo work.

@bartaz bartaz self-assigned this Aug 17, 2022
petermakowski added a commit to petermakowski/vanilla-framework that referenced this issue Aug 25, 2022
@petermakowski
New nav logo padding does not align with content canonical#4530
acead91
@petermakowski petermakowski mentioned this issue Aug 25, 2022
Merged
4 tasks
bartaz pushed a commit that referenced this issue Aug 25, 2022
@petermakowski @bartaz
New nav logo padding does not align with content #4530
2337546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartaz bartaz

@lyubomir-popov lyubomir-popov

@petermakowski petermakowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New nav logo padding does not align with content #4530 petermakowski/vanilla-framework
4 participants
@bartaz @sowasred2012 @lyubomir-popov @petermakowski