Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Manage your tracker settings" link in Vanilla documentation doesn't work #4959

Closed
jferreira-godaddy opened this issue Jan 30, 2024 · 2 comments · Fixed by #4962
Closed

"Manage your tracker settings" link in Vanilla documentation doesn't work #4959

jferreira-godaddy opened this issue Jan 30, 2024 · 2 comments · Fixed by #4962
Labels
Bug 🐛 Guest dev 🤝 Good issue to work on with guest devs

Comments

@jferreira-godaddy
Copy link

Describe the bug

Clicking the link in the website's footer doesn't have any effect on clicking. No network events or console messages.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Vanilla documentation
  2. Scroll down to the end of the page
  3. Click "Manage your tracker settings"
  4. See the hash added to the address bar
  5. Nothing else happens

Expected behavior

I don't know what's the expected behavior, but I am looking for one of:

  • some navigation happens
  • the page scrolls to a specific point
  • a modal opens
  • any other UI element appears

Screenshots

image

Additional context

I subscribed to the Vanilla Newsletter and confirmed my e-mail. I was searching for the newsletter history to review past editions, and that seemed to be the most direct route to what I was seeking.

@bartaz
Copy link
Contributor

bartaz commented Jan 30, 2024

Thanks @Johnylab, indeed something got broken in our cookie policy dialog.

Have you been presented with cookie manager dialog when you first visited the website?

Like this one?
image

Manage your tracked link should open the same dialog. It seems it only works on initial load, but not after cookies are already set.

@bartaz bartaz added the Guest dev 🤝 Good issue to work on with guest devs label Jan 30, 2024
@jferreira-godaddy
Copy link
Author

Yes, I accepted all the cookies in the first render.

@britneywwc britneywwc mentioned this issue Jan 31, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Guest dev 🤝 Good issue to work on with guest devs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants