Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tracker popup #4962

Merged
merged 1 commit into from Jan 31, 2024
Merged

Fix tracker popup #4962

merged 1 commit into from Jan 31, 2024

Conversation

britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Jan 31, 2024

Done

When Manage your tracker settings is clicked, the modal pops up as expected.

Fixes #4959

QA

  • Run demo
  • Scroll down to footer and click on Manage your tracker settings
  • Tracker window should appear

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

Screenshot 2024-01-31 at 11 21 27鈥疉M

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4962.demos.haus

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks!

@bartaz bartaz merged commit cd1e28d into canonical:main Jan 31, 2024
5 checks passed
@britneywwc britneywwc deleted the cookie-modal branch February 9, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Manage your tracker settings" link in Vanilla documentation doesn't work
3 participants