Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bolded headings width mismatches with side navigation #4988

Closed
britneywwc opened this issue Feb 9, 2024 · 1 comment
Closed

Bolded headings width mismatches with side navigation #4988

britneywwc opened this issue Feb 9, 2024 · 1 comment
Assignees
Labels
Bug 🐛 Guest dev 🤝 Good issue to work on with guest devs

Comments

@britneywwc
Copy link
Contributor

britneywwc commented Feb 9, 2024

Describe the bug

  • When p-side-navigation__heading--linked is hovered over, it doesn't cover the full width

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://vanillaframework.io/docs/examples/patterns/side-navigation/accordion
  2. Make sure that the accordion is in full width view (not in toggle side navigation view)
  3. Hover over Troubleshoot
  4. Notice the bug

Expected behavior

It should cover the full width of the link, similar to the other links.

Screenshots
Bug:
Screenshot 2024-02-09 at 3 50 26 PM

Expected:
Screenshot 2024-02-09 at 3 50 30 PM

Desktop (please complete the following information):

  • OS: macOS Sonoma 14.2
  • Browser: Chrome
  • Version: 121.0.6167.139
@bartaz bartaz added the Guest dev 🤝 Good issue to work on with guest devs label Feb 26, 2024
@bartaz
Copy link
Contributor

bartaz commented Feb 27, 2024

It seems to be caused by max-width on headings.

Likely adding max-width: none; on p-side-navigation__heading--linked would fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Guest dev 🤝 Good issue to work on with guest devs
Projects
None yet
Development

No branches or pull requests

3 participants