Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix width of bold linked heading on hover in side-navigation #5009

Merged
merged 4 commits into from Feb 29, 2024

Conversation

codeEmpress1
Copy link
Contributor

@codeEmpress1 codeEmpress1 commented Feb 28, 2024

Done

  • Fix width of bold linked heading on hover in side-navigation
    [List of work items including drive-bys]

Fixes [list issues/bugs if needed]
#4988

QA

  • Open demo
  • [Add QA steps]
  • Review updated documentation:
    • [List any updated documentation for review]

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

Before

Screenshot from 2024-02-28 16-06-26

After

Screenshot from 2024-02-28 16-06-03

[if relevant, include a screenshot or screen capture]

@webteam-app
Copy link

Demo starting at https://vanilla-framework-5009.demos.haus

@@ -525,6 +525,10 @@
padding-left: $spv--small;
}

.p-side-navigation__heading--linked {
max-width: none;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCSS linting is failing on this one, because we already have .p-side-navigation__heading--linked defined below, so these could be joined together.

But to make it even better, I think we can put the max-width inside the %side-navigation__heading definition earlier in the file, so it will apply to ALL headings (not just linked).

@bartaz bartaz merged commit 4902453 into canonical:main Feb 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants