Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated styles for headings, buttons and grid #3943

Merged
merged 3 commits into from
Aug 20, 2021
Merged

Remove deprecated styles for headings, buttons and grid #3943

merged 3 commits into from
Aug 20, 2021

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Aug 20, 2021 •
edited

Done

Remove deprecated styles related to:

  • headings (--one, --two, etc class names), updated examples that still used those
  • neutral button was removed, updated any examples that still used them
  • removed is-active button
  • removed unnecessary button icon mixin
  • removed deprecated grid settings

Part of #3744

QA

  • Open demo
  • Check the code to see which examples were affected
  • Make sure affected examples render as expected
  • Make sure relevant doc pages don't include deprecated docs anymore

@webteam-app
Copy link

Demo starting at https://vanilla-framework-3943.demos.haus

@bartaz bartaz changed the base branch from master to vanilla-3.0 August 20, 2021 12:43
@bartaz bartaz marked this pull request as ready for review August 20, 2021 12:52
@bartaz bartaz changed the title Vanilla 3.0 remove deprecated pt 2 Remove deprecated styles for headings, buttons and grid Aug 20, 2021
sowasred2012
sowasred2012 approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@sowasred2012 sowasred2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Out of interest, I ran the parker checks, filesize is already down just below 300kb, we could adjust the limit back down?

@bartaz bartaz merged commit d82bd84 into canonical:vanilla-3.0 Aug 20, 2021
@bartaz bartaz deleted the vanilla-3.0-remove-deprecated-pt-2 branch August 20, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sowasred2012 sowasred2012 sowasred2012 approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartaz @webteam-app @sowasred2012