Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated navigation styles #3947

Merged
merged 6 commits into from
Aug 27, 2021

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Aug 23, 2021

Done

  • Removes deprecated navigation styles (and sub navigation)
  • Removes deprecated examples and docs
  • Cleans up the navigation code from unnecessary %placeholders (that were used to share styles between deprecated and new versions)

Part of #3744

Code review

  • Because of a lot of changes and code shifting in the file it may be hard to review it in a diff format. Probably it may be easier to look into how the SCSS file looks like in the end.

QA

@webteam-app
Copy link

Demo starting at https://vanilla-framework-3947.demos.haus

@bartaz bartaz changed the title WIP: Remove deprecated navigation styles Remove deprecated navigation styles Aug 26, 2021
@bartaz bartaz marked this pull request as ready for review August 26, 2021 10:04
Copy link
Contributor

@sowasred2012 sowasred2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

lgtm

@bartaz bartaz merged commit 084d881 into canonical:vanilla-3.0 Aug 27, 2021
@bartaz bartaz deleted the vanilla-3.0-navigation branch August 27, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants