Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated icon styles #3960

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Remove deprecated icon styles #3960

merged 2 commits into from
Aug 31, 2021

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Aug 30, 2021 •
edited

Done

Remove last batch of deprecated styling (icons).

Fixes #3744

QA

  • Open demo
  • Make sure all deprecated icons are removed from the docs page and the code
  • Drive-by: make sure all icons are correctly displayed in cards in the docs (next to their label)

@webteam-app
Copy link

Demo starting at https://vanilla-framework-3960.demos.haus

@sowasred2012 sowasred2012 self-assigned this Aug 31, 2021
sowasred2012
sowasred2012 approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@sowasred2012 sowasred2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - gonna cause some fun merge conflicts on the p-card__inner PR for me though 🤣

@bartaz bartaz merged commit 6775bee into canonical:vanilla-3.0 Aug 31, 2021
@bartaz bartaz deleted the vanilla-3.0-deprecated-icons branch August 31, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sowasred2012 sowasred2012 sowasred2012 approved these changes

Assignees

@sowasred2012 sowasred2012

Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartaz @webteam-app @sowasred2012