-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datalist to examples #3984
Add datalist to examples #3984
Conversation
Demo starting at https://vanilla-framework-3984.demos.haus |
ed6e159
to
4d2f0fc
Compare
It seems it's only Chrome that adds this native arrow on hover/focus when list is available. Firefox doesn't do anything at all. So I think it is fine if we just hide it in Chrome as well. Having a look through MDN and stack overflow it seems it is possible: https://stackoverflow.com/questions/20937475/remove-datalist-dropdown-arrow-in-chrome input::-webkit-calendar-picker-indicator {
opacity: 0;
} I think we should add something like that, but probably limit it to inputs that have datalist defined: input[list]::-webkit-calendar-picker-indicator {
opacity: 0;
} Also there doesn't seem to be any way to style the list itself. This is a native element similar to select or autocomplete and it can't be styled with CSS. |
@petesfrench Can you also add this example to "Forms" documentation page ( |
ea158b0
to
e3f4d47
Compare
@bartaz Is the drop down supposed to span the length of the input? Similar to it does on a select? |
e3f4d47
to
eee1a2e
Compare
I don't think we can do anything about it, it is controlled by the browser and styles won't affect it. |
@petesfrench All looks good. Overall I think this addition can be counted as a feature, so would be good to:
|
5947bac
to
f5a8854
Compare
Done
Fixes #2673
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots