Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove p-link--external #4069

Merged
merged 6 commits into from
Oct 18, 2021
Merged

Conversation

sowasred2012
Copy link
Contributor

@sowasred2012 sowasred2012 commented Oct 14, 2021

Done

  • Removed .p-external--link and associated examples
  • Added note about removal to upgrade guide

Fixes #3375

QA

  • Open demo
  • See that external links aren't mentioned
  • Click around https://vanilla-framework-4069.demos.haus and similar pages, see that no links have the icon
  • Check the codebase for mentions of p-link--external, there should be none.
    • the exception is for the icon itself, p-icon--external-link still exists
  • Review updated documentation:

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4069.demos.haus

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants