-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove checkbox & radio base styles #4072
Merged
sowasred2012
merged 16 commits into
canonical:vanilla-3.0
from
sowasred2012:remove-checkbox-radio
Oct 19, 2021
Merged
Remove checkbox & radio base styles #4072
sowasred2012
merged 16 commits into
canonical:vanilla-3.0
from
sowasred2012:remove-checkbox-radio
Oct 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo starting at https://vanilla-framework-4072.demos.haus |
sowasred2012
added
Don't merge
Review: Code needed
Review: Design needed
Review: QA needed
and removed
Don't merge
labels
Oct 15, 2021
sowasred2012
force-pushed
the
remove-checkbox-radio
branch
from
October 18, 2021 15:13
84e510d
to
8cc0e84
Compare
sowasred2012
changed the title
WIP Remove checkbox radio base styles
Remove checkbox & radio base styles
Oct 18, 2021
sowasred2012
force-pushed
the
remove-checkbox-radio
branch
from
October 19, 2021 10:33
9da60f0
to
5230e6b
Compare
sowasred2012
force-pushed
the
remove-checkbox-radio
branch
from
October 19, 2021 11:04
5230e6b
to
7d7de24
Compare
bartaz
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention: