Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checkbox & radio base styles #4072

Merged
merged 16 commits into from
Oct 19, 2021

Conversation

sowasred2012
Copy link
Contributor

@sowasred2012 sowasred2012 commented Oct 15, 2021

Done

  • Moved base checkbox & radio styles to pattern, and dropped support for base styles
  • Removed base examples
  • Added notes to upgrade guide about using the pattern instead
  • Moved the indeterminate example to patterns

QA

  • Open demo
  • Look for checkbox and radio examples in the Base column, see that there are none
  • View all checkbox and radio examples in the Pattern column (including the alignment example), see that there are no base elements and that the examples aren't broken.
  • Review updated documentation:

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4072.demos.haus

@sowasred2012 sowasred2012 changed the title WIP Remove checkbox radio base styles Remove checkbox & radio base styles Oct 18, 2021
@bartaz
Copy link
Contributor

bartaz commented Oct 19, 2021

This is likely not related to this PR (this bug seems to be on live version of Vanilla), but seems we missed it and could be fixed now:

Screenshot 2021-10-19 at 14 51 39

Muted heading variant of radio button doesn't use muted text color.

@sowasred2012 sowasred2012 merged commit 17f3389 into canonical:vanilla-3.0 Oct 19, 2021
@sowasred2012 sowasred2012 deleted the remove-checkbox-radio branch October 19, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants