-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 12 col breakpoint from medium to large #4078
Update 12 col breakpoint from medium to large #4078
Conversation
Demo starting at https://vanilla-framework-4078.demos.haus |
If anything breaks it is likely going to be on ubuntu.com or another site that relies on the currentbreakpoints. Nevertheless I think we should procede with this and include qa steps in the upgrade guide. |
@@ -116,7 +116,7 @@ | |||
} | |||
} | |||
|
|||
@media (min-width: $breakpoint-medium) { | |||
@media (min-width: $breakpoint-large) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it should use $threshold-6-12-col
? This way it would be connected to grid rather than screen size. I guess it may be closer to what we want.
@sowasred2012 @lyubomir-popov While working on grid-based show/hide utils I started some exploration about vanilla breakpoints and how they relate to grid and utils. I feel like we may need more discussion on what we want to achieve to avoid fixing the symptoms. Let's have some catch up call tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We will follow up on this one in #4081.
Done
Fixes #3209
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention: