-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document vertical spacing utilities #4092
Conversation
Demo starting at https://vanilla-framework-4092.demos.haus |
7cd4f1a
to
0f41060
Compare
0f41060
to
f5a83ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
806cae5
to
a67e9d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggested rewording of do/donts
Co-authored-by: Bartek Szopka <83575+bartaz@users.noreply.github.com>
It also looks bit weird to have HTML code in the example text. I don't think we do it anywhere. It makes it look a bit confusing or as an error. Maybe instead of |
I was using this as a basis: https://vanillaframework.io/docs/examples/utilities/margin-collapse |
@bartaz also - with columns it looks like this, which looks quite weird to me: |
Done
Adding documentation and example around vertical spacing (
u-sv
) utilities.Fixes #4026
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention: