Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused pagination link #4094

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

sowasred2012
Copy link
Contributor

Done

Removed .p-article-pagination__link, as it wasn't being used anywhere (its variants are).

Fixes #4025

QA

  • Make sure tests pass, the class wasn't used so it shouldn't impact anything.

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4094.demos.haus

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Even thought it's not used anywhere maybe worth adding to upgrade guide that it was removed? So if anyone searches for it they'd know.

@sowasred2012 sowasred2012 merged commit 2374bd2 into canonical:vanilla-3.0 Oct 25, 2021
@sowasred2012 sowasred2012 deleted the pagination-link branch October 25, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants