Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up breakpoints in utilities #4096

Merged
merged 5 commits into from
Oct 27, 2021
Merged

Clean-up breakpoints in utilities #4096

merged 5 commits into from
Oct 27, 2021

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Oct 26, 2021 •
edited

Done

  • updates utilities (show/hide, float, equal height, image position) to work on consistent ranges of breakpoints
  • adds a responsive template example to test responsive behaviours (and snapshot it in Percy on all 3 ranges)
  • move simple component breakpoints from --medium to a grid-based threshold

Fixes #4085

QA

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4096.demos.haus

@bartaz bartaz changed the title WIP: Breakpoints cleanup Clean-up breakpoints in utilities Oct 27, 2021
@bartaz bartaz marked this pull request as ready for review October 27, 2021 10:36
sowasred2012
sowasred2012 approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@sowasred2012 sowasred2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

templates/docs/examples/templates/responsive.html
@@ -0,0 +1,105 @@
{% extends "_layouts/examples.html" %}
{% block title %}Responsive behaviours{% endblock %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great (the whole page, not just this title)

@bartaz bartaz merged commit d65c812 into canonical:vanilla-3.0 Oct 27, 2021
@bartaz bartaz deleted the breakpoints-cleanup branch October 27, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sowasred2012 sowasred2012 sowasred2012 approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartaz @webteam-app @sowasred2012