Var mapping

[lyubomir-popov]

Done

Add list of variable remappings to the 3.0 upgrade guide.

QA: compare the values with the actual rem units, ensure they are matching between old/new vars.

[webteam-app]

Demo starting at https://vanilla-framework-4106.demos.haus

[anthonydillon]

Few suggestions and a question in the code

[anthonydillon]

if $sph--small and $sph--large are the same as $spv--small and $spv--large why not drop the concept of v and h and just have sp-large, sp-small, etc?

[bartaz]

For vertical spacing we have much more options than for horizontal and we wanted to keep this distinction.

We need vertical spacing from x-small up to x-large, but we don't want people to use that much spacing horizontally between elements. So we kept separate sph and spv var families to better define which options are available for which type of spacing.

[lyubomir-popov]

Thanks @bartaz for summarizing this. Basically we want to keep track of what is being used vertically vs horizontally, and the prefix allows us to see at a glance that $sph-medium is not used or needed for example. So if someone finds themselves needing that value, they will be able to immediately tell that they are about to introduce something new to the framework and hopefully double check if it is indeed necessary, or whether an existing var might be a better choice.

[anthonydillon]

Thanks that is clear 👍

[lyubomir-popov]

@anthonydillon I've committed your suggestions, please have another look.

[anthonydillon]

LGTM 👍