-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up media query breakpoints in components #4107
Clean up media query breakpoints in components #4107
Conversation
Demo starting at https://vanilla-framework-4107.demos.haus |
@@ -24,7 +24,7 @@ | |||
use 13rem. This value should be adjusted on the application level based on | |||
the content that needs to stay visible on the screen. | |||
*/ | |||
@media (min-width: 772px) { | |||
@media (min-width: 620px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are in local CSS in the examples, so we need to update px values in example code.
@@ -5,7 +5,7 @@ | |||
<style> | |||
{% include "docs/examples/layouts/application/_styles.css" %} | |||
|
|||
@media (min-width: 772px) { | |||
@media (min-width: 620px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are in local CSS in the examples, so we need to update px values in example code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Done
Fixes #4082
QA