-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline labels #4110
Merged
sowasred2012
merged 5 commits into
canonical:vanilla-3.0
from
sowasred2012:inline-labels
Nov 2, 2021
Merged
Inline labels #4110
sowasred2012
merged 5 commits into
canonical:vanilla-3.0
from
sowasred2012:inline-labels
Nov 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo starting at https://vanilla-framework-4110.demos.haus |
sowasred2012
added
Don't merge
Question ❓
Further information is requested
and removed
Question ❓
Further information is requested
labels
Nov 1, 2021
sowasred2012
force-pushed
the
inline-labels
branch
from
November 2, 2021 12:05
93de5f4
to
d5f1093
Compare
bartaz
reviewed
Nov 2, 2021
bartaz
reviewed
Nov 2, 2021
bartaz
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bartaz
added
Review: Code +1
Review: QA +1
and removed
Review: QA needed
Review: Code needed
labels
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
inline-block
, rather thanblock
.Fixes #4104
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention: