Initial improvements to upgrade guide #4119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://vanilla-framework-4119.demos.haus |
bartaz
changed the title
bartaz
force-pushed
the
upgrade-guide-updates
branch
2 times, most recently
from
82a9744
to
2ceeab0
Compare
|
bethcollins92
force-pushed
the
upgrade-guide-updates
branch
from
2ceeab0
to
cc23243
Compare
|
The most recent commit is with some fixes from the QA I did. The text-max-width section still needs rewording but we can update it once we add the class |
|
FYI - |
|
Also, the grid looks broken in this demo. Just noting it here so I don't forget to mention it |
bartaz
force-pushed
the
upgrade-guide-updates
branch
from
cc23243
to
2b92e0c
Compare
bartaz
changed the title
bethcollins92
approved these changes
Dec 10, 2021
Co-authored-by: Beth Collins <beth.collins@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial improvements around 3.0 upgrade guide.
To be continues in canonical-web-and-design/vanilla-squad#1024 epic
QA
Check upgrade guide: https://vanilla-framework-4119.demos.haus/docs/upgrade-guide-v3
Make sure it reads ok
Make sure any missing things are listed as part of canonical-web-and-design/vanilla-squad#1024 epic