Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stylelint to v14 #4142

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Update stylelint to v14 #4142

merged 1 commit into from
Nov 26, 2021

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Nov 23, 2021 •
edited

Done

Updated stylelint to v14 to make sure VSCode extension works with it.
Reordered rules in stylelint config to make it more structured.

QA

  • Make sure CI checks pass
  • Pull the branch locally in VSCode
  • Make sure stylelint in VSCode works (try reordering some CSS props or break some other rules)

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4142.demos.haus

@bartaz
Copy link
Contributor Author

bartaz commented Nov 23, 2021

CircleCI fails because of node version. We need to fix #4027 first....

@bartaz bartaz merged commit b6a32f6 into canonical:main Nov 26, 2021
@bartaz bartaz deleted the stylelint-upgrade branch November 26, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethcollins92 bethcollins92 bethcollins92 approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
Iteration: 21-47 - 22 Nov to 3 Dec 2021
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bartaz @webteam-app @bethcollins92 @cristinadresch