Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official image for CircleCi with Python and node #4143

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Nov 23, 2021

Done

Update CircleCI image from our old dev docker image to official image with Python and node.

QA

  • Make sure all CI passes (especially circleci/percy)

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4143.demos.haus

@bartaz bartaz force-pushed the circleci-ubuntu-latest branch 6 times, most recently from 14baaf5 to 792fb34 Compare November 23, 2021 13:22
@bartaz bartaz changed the title Use ubuntu:latest for CircleCi Use official image for CircleCi with Python and node Nov 23, 2021
@bartaz bartaz marked this pull request as ready for review November 23, 2021 15:23
Copy link
Contributor

@jkfran jkfran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartaz bartaz merged commit dc71f40 into canonical:main Nov 24, 2021
@bartaz bartaz deleted the circleci-ubuntu-latest branch May 27, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants