Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run script to use essential build #4149

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

bethcollins92
Copy link
Contributor

Done

  • Move examples.scss to /docs
  • Add build:essential script
  • Edit /run script to use build:essential

QA

  • Check ./run works

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4149.demos.haus

@bartaz
Copy link
Contributor

bartaz commented Nov 24, 2021

Thanks @bethcollins92 , while at it, could you also rename watch:scss:skip-standalone to watch:essential?
And maybe it would be worth adding something about build:essential and watch:essential to our docs in /guildes/hacking.md.

@bethcollins92
Copy link
Contributor Author

Thanks @bartaz, is this enough info?

@bartaz bartaz merged commit 35bae6f into canonical:main Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants