-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theming for chips #4168
Add theming for chips #4168
Conversation
Demo starting at https://vanilla-framework-4168.demos.haus |
@bethcollins92 I think we should have dark chips in the variants example as well: I guess just duplicate whole thing inside the dark strip (in the same example file below current stuff). |
|
||
// Theming | ||
@if ($theme-default-p-chip == 'dark') { | ||
.p-chip { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part seems extremely repetitive, but I'm not sure if we can do anything about it - we do need separate color treatment for each of those variants…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same feeling when writing it but couldn't figure out a way around it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's an extra class that makes the close grey on red... not very readable. Suggestion to remove it in the code.
eeeb338
to
3572689
Compare
@lyubomir-popov The |
Done
Fixes #4158
QA
is-dark
oris-light
class names work as expectedCheck if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention: