Refactor margin/gutter scss maps #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e (they use the same values)
|
Demo starting at https://vanilla-framework-4176.demos.haus |
bartaz
reviewed
Dec 3, 2021
scss/_settings_grid.scss
Outdated
| @@ -16,13 +16,11 @@ $grid-large-col-prefix: #{$grid-column-prefix} !default; | |||
|
|
|||
| $grid-gutter-widths: ( | |||
| small: $sp-unit * 3, | |||
| medium: $sp-unit * 4, | |||
| large: $sp-unit * 4, | |||
There was a problem hiding this comment.
Should these be renamed to default?
bartaz
reviewed
Dec 3, 2021
scss/_settings_grid.scss
Outdated
| large: $sp-unit * 4, | ||
| ) !default; | ||
|
|
||
| $grid-margin-widths: ( | ||
| small: $sp-unit * 2, | ||
| medium: $sp-unit * 3, | ||
| large: $sp-unit * 3, |
There was a problem hiding this comment.
Should this be renamed to default?
|
Please add this somewhere in the upgrade guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Replace medium with large, delete keys (they use same values so no need forseparate vars)
Fixes #3278
QA
map-get($grid-gutter-widths, medium)remainCheck if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver convention:Screenshots
[if relevant, include a screenshot or screen capture]