Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misused aria-label on mobile card table #4179

Merged
merged 3 commits into from
Dec 7, 2021

Conversation

bethcollins92
Copy link
Contributor

@bethcollins92 bethcollins92 commented Dec 6, 2021

Done

  • Updated aria-label to data-heading
  • Updated docs to reflect change

Fixes
#4131

QA

  • Open demo
  • Turn voice over on while reviewing the table, ensure the content of the cells is read out not just the title. Currently the title is read out twice, not sure how to fix this, I tried to use content: attr(data-heading) / ' '; but this hides the title both times.
  • Review updated documentation:
    • /docs/base/tables#responsive

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4179.demos.haus

@bartaz
Copy link
Contributor

bartaz commented Dec 6, 2021

@bethcollins92 thanks! Add this to upgrade guide as well, this is a significant breaking change that devs will need to carefully upgrade.

Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤 did you want to put an a11y label on this PR?

@bethcollins92
Copy link
Contributor Author

@bartaz Added - could you proof read it please?

@bartaz bartaz force-pushed the 4131-fix-misused-aria-label branch from 31f687f to 19839dd Compare December 7, 2021 08:03
@bartaz bartaz merged commit 24c4f90 into canonical:main Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants