Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back labels component #4184

Merged
merged 4 commits into from
Dec 8, 2021
Merged

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Dec 7, 2021

Done

Labels are back to replace non-interactive chips

Fixes #4183

QA

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4184.demos.haus

@bartaz bartaz changed the title WIP: Bring back labels component Bring back labels component Dec 8, 2021
@bartaz bartaz marked this pull request as ready for review December 8, 2021 11:56
Copy link
Contributor

@bethcollins92 bethcollins92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one small spelling change 👍🏼

templates/docs/upgrade-guide-v3.md Outdated Show resolved Hide resolved
Co-authored-by: Beth Collins <beth.collins@canonical.com>
@bartaz bartaz merged commit e15e5fd into canonical:main Dec 8, 2021
@bartaz bartaz deleted the bring-back-labels branch December 8, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring the p-label component back in 3.0
3 participants