Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap font-face definitions in @at-root #4190

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Dec 9, 2021

Done

Make sure font-face declarations are always on root CSS level

Fixes #4182

QA

  • Make sure CI passes and there are no changes in Percy
  • Pull the branch locally, and in some local scss file (for example in standalone example) try nesting font declarations:
.test {
  @include vf-b-placeholders;
  @include vf-b-typography;
}

Make sure in the result CSS @font-face doesn't try to use the .test class name.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4190.demos.haus

Copy link
Contributor

@bethcollins92 bethcollins92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay - LGTM

@bartaz bartaz merged commit 28974b4 into canonical:main Dec 9, 2021
@bartaz bartaz deleted the font-at-root branch December 9, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nesting typography styles makes font-face broken
3 participants