Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contextual menu icon update to upgrade guide #4196

Merged

Conversation

bethcollins92
Copy link
Contributor

@bethcollins92 bethcollins92 commented Dec 13, 2021

Done

  • Added description of the p-icon--contextual-menu update to chevron icons to the upgrade guide.

Fixes #1174

QA

  • Open demo
  • Review updated documentation:
    • New sentence mentioning update in upgrade guide

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@bethcollins92 bethcollins92 added the Documentation 馃摑 Documentation changes or updates label Dec 13, 2021
@webteam-app
Copy link

Demo starting at https://vanilla-framework-4196.demos.haus

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once the small duplication typo is fixed.

Co-authored-by: Bartek Szopka <83575+bartaz@users.noreply.github.com>
@bethcollins92 bethcollins92 merged commit f28cda8 into canonical:main Dec 13, 2021
@bethcollins92 bethcollins92 deleted the 1174-replace-contextual-icon-docs branch December 13, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants