Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the naming of tables and class names more consistent #4210

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Make the naming of tables and class names more consistent #4210

merged 1 commit into from
Dec 15, 2021

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Dec 14, 2021 •
edited

Done

  • Update table heading to be more consistent
  • Add tables to sections that didn't have them before
  • Make sure we consistently don't use . in front of class names

Fixes canonical-web-and-design/vanilla-squad#1176

QA

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4210.demos.haus

@bartaz bartaz added Documentation 📝 Documentation changes or updates Review: QA needed labels Dec 14, 2021
bethcollins92
bethcollins92 approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@bethcollins92 bethcollins92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! getting there woooooo

@bartaz bartaz merged commit 0e9c092 into canonical:main Dec 15, 2021
@bartaz bartaz deleted the consistent-tables branch December 15, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethcollins92 bethcollins92 bethcollins92 approved these changes

Assignees
No one assigned
Labels
Documentation 📝 Documentation changes or updates Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartaz @webteam-app @bethcollins92