Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update homepage #4216

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Conversation

bethcollins92
Copy link
Contributor

Done

  • Update Sketch box to include mentioning Vanilla version compatible
  • Update quickstart section

Fixes #4214

QA

  • Open demo
  • Check the homepage sketch card and quickstart section

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4216.demos.haus

templates/index.html Outdated Show resolved Hide resolved
templates/index.html Outdated Show resolved Hide resolved
templates/index.html Outdated Show resolved Hide resolved
@bartaz
Copy link
Contributor

bartaz commented Dec 15, 2021

I think we have broken this image when removed blazy (there is an image on the right):

Screenshot 2021-12-15 at 13 42 08

would be good to search the project for any blazy references

templates/index.html Outdated Show resolved Hide resolved
@bethcollins92
Copy link
Contributor Author

@bartaz waa didn't spot the images disappearing! Christmas brain. I've replaced all the blazy references now and updated the text

templates/index.html Outdated Show resolved Hide resolved
Co-authored-by: Bartek Szopka <83575+bartaz@users.noreply.github.com>
Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bethcollins92 bethcollins92 merged commit 060fe1e into canonical:main Dec 15, 2021
@bethcollins92 bethcollins92 deleted the 4214-update-homepage branch December 15, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure homepage is up to date
3 participants