Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder migration guide #4218

Merged
merged 4 commits into from
Dec 15, 2021
Merged

Reorder migration guide #4218

merged 4 commits into from
Dec 15, 2021

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Dec 15, 2021 •
edited

Done

  • Reorders migration guide sections and improve heading hierarchy.
  • Adds links to relevant sections of Vanilla docs.

Fixes canonical-web-and-design/vanilla-squad#1172

QA

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4218.demos.haus

bethcollins92
bethcollins92 approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@bethcollins92 bethcollins92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a couple of grammar suggestions. Also can't add a comment in the code as it hasn't been changed but spotted this, could you update please?

Line 240: Active button state has been renames to "processing" (has instead of have)

templates/docs/migration-guide-to-v3.md Outdated Show resolved Hide resolved
templates/docs/migration-guide-to-v3.md Outdated Show resolved Hide resolved
templates/docs/migration-guide-to-v3.md Outdated Show resolved Hide resolved
templates/docs/migration-guide-to-v3.md Outdated Show resolved Hide resolved
templates/docs/migration-guide-to-v3.md Outdated Show resolved Hide resolved
templates/docs/migration-guide-to-v3.md Outdated Show resolved Hide resolved
@bartaz @bethcollins92
Wording and grammar fixes from code review
16d6240 
Co-authored-by: Beth Collins <beth.collins@canonical.com>
@bartaz bartaz merged commit 011d33a into canonical:main Dec 15, 2021
@bartaz bartaz deleted the reorder-migration-guide branch December 15, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethcollins92 bethcollins92 bethcollins92 approved these changes

Assignees
No one assigned
Labels
Documentation 📝 Documentation changes or updates Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartaz @webteam-app @bethcollins92