-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update what's new page #4219
Merged
bethcollins92
merged 4 commits into
canonical:main
from
bethcollins92:4217-update-whats-new
Dec 16, 2021
Merged
Update what's new page #4219
bethcollins92
merged 4 commits into
canonical:main
from
bethcollins92:4217-update-whats-new
Dec 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bethcollins92
added
Review: QA needed
Review: Code needed
Documentation 馃摑
Documentation changes or updates
labels
Dec 15, 2021
Demo starting at https://vanilla-framework-4219.demos.haus |
bartaz
requested changes
Dec 15, 2021
Thanks @bartaz, made those changes |
bethcollins92
force-pushed
the
4217-update-whats-new
branch
from
December 16, 2021 09:36
8908fc6
to
1cc7858
Compare
bartaz
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
Dec 16, 2021
bartaz
reviewed
Dec 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
bartaz
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Fixes #4217
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention: