Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search in navigation to expanding search #4228

Merged
merged 4 commits into from
Jan 10, 2022

Conversation

bethcollins92
Copy link
Contributor

@bethcollins92 bethcollins92 commented Jan 6, 2022

Done

  • Update run script
  • Keep consistency with search box visible in header throughout all pages
  • Update search box to use new expanding search

Fixes #4226

QA

  • Open demo
  • Visit all pages in header
  • Expand and close search, check it works as expected.
  • Search for something and check it works and gives expected results

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4228.demos.haus

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bethcollins92 bethcollins92 merged commit b365f7a into canonical:main Jan 10, 2022
@bethcollins92 bethcollins92 deleted the 4226-update-search-in-nav branch January 10, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old search still being used in Nav on vanilla docs
3 participants