Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add buttons accessibility notes #4236

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Add buttons accessibility notes #4236

merged 2 commits into from
Jan 17, 2022

Conversation

bethcollins92
Copy link
Contributor

@bethcollins92 bethcollins92 commented Jan 11, 2022 •
edited

Done

  • Add buttons accessibility notes. copy doc here

Fixes #4039

QA

  • Open demo
  • Check button accessibility section

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@bethcollins92 bethcollins92 added Review: QA needed Documentation 馃摑 Documentation changes or updates labels Jan 11, 2022
@webteam-app
Copy link

Demo starting at https://vanilla-framework-4236.demos.haus

@bethcollins92 bethcollins92 force-pushed the 4039-buttons-accessibility-notes branch from 439a500 to 81cf8d8 Compare January 17, 2022 09:03
@bethcollins92 bethcollins92 force-pushed the 4039-buttons-accessibility-notes branch from 81cf8d8 to 8735e97 Compare January 17, 2022 09:43
bartaz
bartaz approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartaz bartaz merged commit f87f6fb into canonical:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartaz bartaz bartaz approved these changes

Assignees
No one assigned
Labels
Documentation 馃摑 Documentation changes or updates Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Accessibility Docs] Buttons
3 participants
@bethcollins92 @webteam-app @bartaz