Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo section accessibility doc #4262

Merged

Conversation

bethcollins92
Copy link
Contributor

@bethcollins92 bethcollins92 commented Jan 19, 2022

Done

  • Removed redundant "logo" from each alt attribute in logo section example

Fixes #4052

QA

  • Open demo
  • Check the formatting of the accessibility doc, the content has already been reviewed in the doc

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4262.demos.haus

@bethcollins92 bethcollins92 force-pushed the 4052-logo-section-accessibiity-doc branch from 4012595 to 4874fa9 Compare January 19, 2022 14:12
@bethcollins92
Copy link
Contributor Author

@sowasred2012 If you get a sec would you mind taking a look at this PR please? The text has already been reviewed by dev and ux so it's just a final skim before I can merge

@sowasred2012 sowasred2012 self-assigned this Jan 20, 2022
Copy link
Contributor

@sowasred2012 sowasred2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of suggestions

templates/docs/patterns/logo-section.md Outdated Show resolved Hide resolved
Co-authored-by: Scott Mason Nash <sowasred2012@gmail.com>
@bethcollins92 bethcollins92 merged commit 875b3d7 into canonical:main Jan 20, 2022
@bethcollins92 bethcollins92 deleted the 4052-logo-section-accessibiity-doc branch January 20, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation 馃摑 Documentation changes or updates Review: Code +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility Docs] Logo section
3 participants