-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nested counter to order lists #4264
Conversation
Demo starting at https://vanilla-framework-4264.demos.haus |
@ilayda21 @mtruj013 As this is a new "feature" we are adding new class name this is when the other items on PR checklist start to apply:
|
templates/docs/whats-new.md
Outdated
@@ -21,6 +21,14 @@ When we add, make significant updates, or deprecate a component we update their | |||
</thead> | |||
<tbody> | |||
<!-- 3.00 --> | |||
<tr> | |||
<th><a href="/docs/patterns/lists">Ordered list nested counter</a></th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you link directly to the section?
<th><a href="/docs/patterns/lists">Ordered list nested counter</a></th> | |
<th><a href="/docs/patterns/lists#nested-count">Ordered list nested counter</a></th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃憤
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one tiny suggestion.
Thanks!
Done
Fixes #4074
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots