Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nested counter to order lists #4264

Merged
merged 7 commits into from
Jan 20, 2022

Conversation

ilayda21
Copy link
Contributor

@ilayda21 ilayda21 commented Jan 19, 2022

Done

  • Added nested counter to order lists

Fixes #4074

QA

  • Open docs
  • Open "Nested Count" section
  • Verify item numbers are displayed correctly
  • Open examples
  • Verify item numbers are displayed correctly

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4264.demos.haus

@bartaz
Copy link
Contributor

bartaz commented Jan 20, 2022

@ilayda21 @mtruj013 As this is a new "feature" we are adding new class name this is when the other items on PR checklist start to apply:

@@ -21,6 +21,14 @@ When we add, make significant updates, or deprecate a component we update their
</thead>
<tbody>
<!-- 3.00 -->
<tr>
<th><a href="/docs/patterns/lists">Ordered list nested counter</a></th>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link directly to the section?

Suggested change
<th><a href="/docs/patterns/lists">Ordered list nested counter</a></th>
<th><a href="/docs/patterns/lists#nested-count">Ordered list nested counter</a></th>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one tiny suggestion.
Thanks!

@ilayda21 ilayda21 merged commit 43944f1 into canonical:main Jan 20, 2022
@ilayda21 ilayda21 deleted the ilayda-ordered-list-num branch January 20, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested ordered list where the primary section is always visible, x.1, x.2...
3 participants