Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove middle state in the mobile card view #4265

Merged
merged 4 commits into from
Jan 24, 2022

Conversation

ilayda21
Copy link
Contributor

@ilayda21 ilayda21 commented Jan 20, 2022

Done

  • Grid column min value is updated so that there will be no two column view in the cards.

Fixes #4103

QA

  • Open demo
  • Reduce the screen size between 440 - 410px.
  • Verify unnecessary border is not displayed for the second element.

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4265.demos.haus

@ilayda21 ilayda21 marked this pull request as ready for review January 20, 2022 12:52
@ilayda21 ilayda21 changed the title Make after element transparent Remove middle state in the mobile card view Jan 21, 2022
Copy link
Contributor

@bethcollins92 bethcollins92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@ilayda21 ilayda21 merged commit 88bda0a into canonical:main Jan 24, 2022
@ilayda21 ilayda21 deleted the ilayda-mobile-card-border branch January 24, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table mobile card varient extra border on mid-breakpoint
4 participants