Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed display property to fix raw-HTML side nav wrapping #4266

Merged
merged 3 commits into from
Jan 21, 2022

Conversation

mtruj013
Copy link
Contributor

@mtruj013 mtruj013 commented Jan 20, 2022

Done

  • Set display: block for raw-HTML side nav list text to fix wrapping issue when using the <code> tag

Fixes #3988

QA

  • Open example demo
  • Open side nav and make sure everything wraps as expected where <code> tag is used

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

Screenshot 2022-01-20 at 16 05 53

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4266.demos.haus

@bartaz
Copy link
Contributor

bartaz commented Jan 21, 2022

@mtruj013 Could you please add an examples to make sure it works? Just add it to "raw html" example I think.

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartaz bartaz merged commit b0ef36b into canonical:main Jan 21, 2022
@mtruj013 mtruj013 deleted the fix-side-nav branch January 21, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Raw HTML" side navigation wraps wrong when there is code in titles
3 participants